Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate MyInfo fields for V3 (step 3 - drop support) #1073

Merged
merged 7 commits into from
Feb 11, 2021

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented Feb 3, 2021

To be merged for the release after #1071 and after the scripts in #1072 have been run

Problem

The following MyInfo fields are set to return empty strings, and therefore should be deprecated:

  • Home number
  • Billing address
  • Mailing address
  • Highest education level
  • School name
  • Graduation year

Solution

The deprecation requires 3 steps:

  1. Stop allowing admins to add these fields
  2. Database migration to convert these fields to regular (non-MyInfo) fields
  3. Drop support for these fields

This PR addresses step 3. Here, we remove the deprecated fields from the codebase.

Tests

  • Run the following query in production and ensure that you get 0 results: db.getCollection('forms').find({ 'form_fields.myInfo.attr': { $in: ['homeno', 'mailadd', 'billadd', 'gradyear', 'edulevel', 'schoolname']} })
  • Submit a form with all MyInfo fields

@mantariksh
Copy link
Contributor Author

to be merged and released AFTER db scripts have been run

@mantariksh mantariksh changed the base branch from deprecate-myinfo/frontend to develop February 5, 2021 03:24
@mantariksh mantariksh merged commit ae451b3 into develop Feb 11, 2021
@mantariksh mantariksh deleted the deprecate-myinfo/drop-support branch April 13, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants